Add basic autocompletion for Zsh #689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
part of #278 |
|
I'm a little concerned about keeping this up to date with the CLI, but we can add it for now on the basis that slightly out-of-date completions are better than no completions, and our CLI aims to be backwards compatible. However, I'd prefer not to clutter the root directory with this. Regarding actual installation, for now just providing them in the repo is better than nothing. When we figure out the best way to install it automatically, we can always |
knight42
force-pushed
the
zsh-auto-completion
branch
from
87e3c7b to
637b0ac
Compare
knight42
force-pushed
the
zsh-auto-completion
branch
from
637b0ac to
f0d04a9
Compare
|
@Diggsey updated as you said :) |
|
Thanks! Test failure looks spurious, so merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsolved problem:
Should I hard code this file into somewhere and generate it in a proper place, say
~/.cargo/_rustup(then ask users to copy it to /usr/share/zsh/site-functions),or simply let rustup copy this file to
~/.cargo/_rustup?